feat(debug): Enable debugging for Python37 #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sriram-mv
requested changes
Mar 13, 2019
| @@ -293,13 +294,21 @@ def _get_entry_point(runtime, debug_options=None): | |||
| "/var/runtime/awslambda/bootstrap.py" | |||
| ] | |||
|
|
|||
| elif runtime == Runtime.python37.value: | |||
There was a problem hiding this comment.
at some point we need to clean up with the if else and make it cleaner. Maybe something like a dictionary key dispatch would work here.
Not: Not blocking.
2 tasks
sriram-mv
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Dependent on lambci/docker-lambda#172
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.