fix: add timeouts on docker local-invoke, start-api and start-lambda integration tests #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- cause the builds to fail on appveyor rather than halting the test forever, resulting in a lengthy build timeout.
sriram-mv
changed the title
|
Might need to adopt https://github.com/pytest-dev/pytest-rerunfailures as well. |
sanathkr
reviewed
Oct 18, 2019
| @@ -1,13 +1,13 @@ | |||
| coverage==4.3.4 | |||
| tox==2.2.1 | |||
sanathkr
reviewed
Oct 18, 2019
| pytest-cov==2.4.0 | ||
| # astroid > 2.0.4 is not compatible with pylint1.7 | ||
| astroid>=1.5.8,<2.1.0 | ||
| pylint==1.7.2 | ||
|
|
||
| # Test requirements | ||
| pytest==3.1.0 | ||
| py==1.4.33 | ||
| pytest==3.6.0 |
There was a problem hiding this comment.
This might cause some weird test failures/warnings I think.
There was a problem hiding this comment.
Are you talking about removing py or the pytest upgrade?
There was a problem hiding this comment.
I had to upgrade pytest to even be able to use pytest-timeouts.
sanathkr
reviewed
Oct 18, 2019
| @@ -30,6 +31,7 @@ def setUp(self): | |||
| def tearDown(self): | |||
| os.remove(self.events_file_path) | |||
|
|
|||
| @pytest.mark.timeout(timeout=300, method='thread') | |||
There was a problem hiding this comment.
yeah its seconds.
|
Gonna increase the lambda timeouts on the integration test templates. Looks like 3 seconds is too low (sporadically) when running docker linux containers on appveyor windows. |
- removal of python2 matrix - change to always activation of virtualenv on windows on every stage
- infinite timeout, but each of these tests has an individual timeout of 300s
sriram-mv
force-pushed
the
pytest_timeout
branch
2 times, most recently
from
55c5426
to
a1e2635
Compare
sriram-mv
force-pushed
the
pytest_timeout
branch
from
a1e2635
to
11c569c
Compare
- temporarily remove smoke tests on windows matrix
sriram-mv
force-pushed
the
pytest_timeout
branch
from
f7d22cd
to
3232aa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forever, resulting in a lengthy build timeout.
pytest-timeout, also do we needtox?Issue #, if available:
Description of changes:
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.