Package and deploy in one command #1532
Conversation
- need to add additional parameters over from package.
| @@ -96,6 +99,14 @@ | |||
| "changes to be made to the stack. The default behavior is to return a" | |||
| "non-zero exit code.", | |||
| ) | |||
| @click.option( | |||
There was a problem hiding this comment.
I know we talked about this before, why is this explicitly required? can't we default to using JSON for the intermediate template?
There was a problem hiding this comment.
Sure, we can. user had the option with package, do we gain anything by removing it from deploy?
There was a problem hiding this comment.
There is no obvious user benefit of this flag in sam deploy. Why expose then?
| region=region, | ||
| profile=profile, | ||
| ) as package_context: | ||
| package_context.run() |
There was a problem hiding this comment.
why are you packaging always? This would be a breaking change
There was a problem hiding this comment.
No. its an attempt to package, if the codeuri's already contain packaged contents, we do not repackage.
There was a problem hiding this comment.
This is skirting the lines of a breaking change. Is there any other mechanism to create two clear code paths, one for previous experience and other for new one?
And, this relies on the fact that sam package is idempotent. That's an undocumented assumption of sam package.
There was a problem hiding this comment.
#1533. Added this question here.
- `samcli/commands/deploy/command.py` has high number of local variables, because of the nature of command, it has high number of arguments.
* feat: beginnings of package and deploy together * fix: plumb through configuration - need to add additional parameters over from package. * fix: conditional check to print text on package during deploy * fix: exceptions for `package` * lint: local variables rule - `samcli/commands/deploy/command.py` has high number of local variables, because of the nature of command, it has high number of arguments.
* feat: beginnings of package and deploy together * fix: plumb through configuration - need to add additional parameters over from package. * fix: conditional check to print text on package during deploy * fix: exceptions for `package` * lint: local variables rule - `samcli/commands/deploy/command.py` has high number of local variables, because of the nature of command, it has high number of arguments.
if the template is left unspecified, built artifacts are chosen and s3 bucket is optionally needed to deploy in one command.
existing workflows to package and deploy do not break.
Write Design Document (Do I need to write a design document?)
Write unit tests
Write/update functional tests
Write/update integration tests
make prpassesWrite documentation
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.