Add warning when no credentials found. #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanathkr
reviewed
Oct 5, 2017
env.go
Outdated
| if creds, err := sess.Config.Credentials.Get(); err == nil { | ||
| creds, err := sess.Config.Credentials.Get() | ||
| if err != nil { | ||
| log.Printf("WARNING: No AWS credentials found. Configure credentials to speed execution.") |
There was a problem hiding this comment.
Can you be a bit more verbose here to say "Missing credentials may lead to low startup times as detailed in #134"
There was a problem hiding this comment.
Sounds good to me. Hopefully this is what you had in mind.
sanathkr
suggested changes
Oct 5, 2017
m5
force-pushed
the
credential-failure-warning
branch
from
60df459
to
ceda0ed
Compare
…a very long time to fail. Change copy as suggested by @sanathkr
m5
force-pushed
the
credential-failure-warning
branch
from
ceda0ed
to
a670f47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a machine with no AWS credentials configured, each execution takes an additional 20 seconds to complete. This time is spent waiting for the connection to 169.254.169.254 to time out.
I believe this is the cause of issue #134
If aws-sam-local is rarely run on an ec2 instance, it may be better to disable the EC2RoleProvider by default.