Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Set the CORS "Access-Control-Allow-Credentials" for local running" #1664

Merged
merged 2 commits into from
Dec 16, 2019
Merged

Revert "Set the CORS "Access-Control-Allow-Credentials" for local running" #1664

merged 2 commits into from
Dec 16, 2019

Conversation

sanathkr
Copy link
Contributor

Reverts #1648

@jfuss jfuss merged commit bc68c21 into develop Dec 16, 2019
@dkryptr
Copy link
Contributor

dkryptr commented Apr 16, 2020

@sanathkr @jfuss I just noticed the merge request I had made is being reverted. Is there an issue either of you can link for why?

@dkryptr dkryptr mentioned this pull request Apr 16, 2020
Open
@jfuss
Copy link
Contributor

jfuss commented Apr 16, 2020

@CGreenburg I don't specifically recall but probably something to do with not enough testing around it (guessing by looking at the pr).

@aahung aahung deleted the revert-1648-patch-1 branch November 18, 2020 09:26
@hoffa hoffa mentioned this pull request Jan 17, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfuss jfuss jfuss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sanathkr @dkryptr @jfuss