fix: samconfig design accuracy #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanathkr
reviewed
Jan 3, 2020
sanathkr
reviewed
Jan 3, 2020
sanathkr
approved these changes
Jan 3, 2020
Why is this change necessary? * Implementation based on the samconfig design changed course based on well reasoned discussions, but was not reflected back onto the design doc. How does it address the issue? * Design reflects more of present day implementation of `samconfig.toml` What side effects does this change have? * None TODO * Add more detail on multiple configuration files and its future.
sriram-mv
force-pushed
the
samconfig_design_doc_corrections
branch
from
2c0307b
to
16bd6b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change necessary?
well reasoned discussions, but was not reflected back onto the design
doc.
How does it address the issue?
samconfig.tomlWhat side effects does this change have?
TODO
Issue #, if available:
Description of changes:
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.