Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nodejs8.10 Init #1716

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Remove nodejs8.10 Init #1716

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cf45b2
Remove nodejs8.10 Init
awood45 Jan 6, 2020
6aaee56
Merge branch 'develop' into node8-deprecation
awood45 Jan 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions samcli/local/common/runtime_template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
],
"nodejs": [
{
"runtimes": ["nodejs12.x", "nodejs10.x", "nodejs8.10"],
"runtimes": ["nodejs12.x", "nodejs10.x"],
"dependency_manager": "npm",
"init_location": os.path.join(_templates, "cookiecutter-aws-sam-hello-nodejs"),
"build": True,
Expand Down Expand Up @@ -76,7 +76,6 @@
"ruby2.5": ["bundler"],
"nodejs12.x": ["npm"],
"nodejs10.x": ["npm"],
"nodejs8.10": ["npm"],
"dotnetcore2.1": ["cli-package"],
"dotnetcore2.0": ["cli-package"],
"dotnetcore1.0": ["cli-package"],
Expand Down Expand Up @@ -107,7 +106,6 @@
"dotnetcore2.1",
# older nodejs runtimes
"nodejs10.x",
"nodejs8.10",
# older python runtimes
"python3.7",
"python3.6",
Expand Down
28 changes: 14 additions & 14 deletions tests/integration/init/schemas/test_init_with_schemas_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class TestBasicInitWithEventBridgeCommand(SchemaTestDataSetup):
def test_init_interactive_with_event_bridge_app_aws_registry(self):
# WHEN the user follows interactive init prompts
# 1: AWS Quick Start Templates
# 12: Java runtime
# 11: Java runtime
# 1: dependency manager maven
# eb-app-maven: response to name
# 3: select event-bridge app from scratch
Expand All @@ -28,7 +28,7 @@ def test_init_interactive_with_event_bridge_app_aws_registry(self):

user_input = """
1
12
11
1
eb-app-maven
3
Expand All @@ -52,7 +52,7 @@ def test_init_interactive_with_event_bridge_app_partner_registry(self):
# setup schema data
# WHEN the user follows interactive init prompts
# 1: AWS Quick Start Templates
# 12: Java Runtime
# 11: Java Runtime
# 1: dependency manager maven
# eb-app-maven: response to name
# 3: select event-bridge app from scratch
Expand All @@ -62,7 +62,7 @@ def test_init_interactive_with_event_bridge_app_partner_registry(self):

user_input = """
1
12
11
1
eb-app-maven
3
Expand Down Expand Up @@ -97,7 +97,7 @@ def test_init_interactive_with_event_bridge_app_partner_registry(self):
def test_init_interactive_with_event_bridge_app_pagination(self):
# WHEN the user follows interactive init prompts
# 1: AWS Quick Start Templates
# 12: Java Runtime
# 11: Java Runtime
# 1: dependency manager maven
# eb-app-maven: response to name
# 3: select event-bridge app from scratch
Expand All @@ -109,7 +109,7 @@ def test_init_interactive_with_event_bridge_app_pagination(self):

user_input = """
1
12
11
1
eb-app-maven
3
Expand All @@ -135,7 +135,7 @@ def test_init_interactive_with_event_bridge_app_pagination(self):
def test_init_interactive_with_event_bridge_app_customer_registry(self):
# WHEN the user follows interactive init prompts
# 1: AWS Quick Start Templates
# 12: Java Runtime
# 11: Java Runtime
# 1: dependency manager maven
# eb-app-maven: response to name
# 3: select event-bridge app from scratch
Expand All @@ -145,7 +145,7 @@ def test_init_interactive_with_event_bridge_app_customer_registry(self):

user_input = """
1
12
11
1
eb-app-maven
3
Expand Down Expand Up @@ -180,7 +180,7 @@ def test_init_interactive_with_event_bridge_app_customer_registry(self):
def test_init_interactive_with_event_bridge_app_aws_schemas_python(self):
# WHEN the user follows interactive init prompts
# 1: AWS Quick Start Templates
# 9: Python 3.7
# 8: Python 3.7
# eb-app-maven: response to name
# 3: select event-bridge app from scratch
# Y: Use default profile
Expand All @@ -189,7 +189,7 @@ def test_init_interactive_with_event_bridge_app_aws_schemas_python(self):

user_input = """
1
9
8
eb-app-python37
3
Y
Expand All @@ -210,7 +210,7 @@ def test_init_interactive_with_event_bridge_app_non_default_profile_selection(se
self._init_custom_config("mynewprofile", "us-west-2")
# WHEN the user follows interactive init prompts
# 1: AWS Quick Start Templates
# 9: Python 3.7
# 8: Python 3.7
# eb-app-maven: response to name
# 3: select event-bridge app from scratch
# N: Use default profile
Expand All @@ -221,7 +221,7 @@ def test_init_interactive_with_event_bridge_app_non_default_profile_selection(se

user_input = """
1
9
8
eb-app-python37
3
N
Expand All @@ -246,7 +246,7 @@ def test_init_interactive_with_event_bridge_app_non_supported_schemas_region(sel
self._init_custom_config("default", "cn-north-1")
# WHEN the user follows interactive init prompts
# 1: AWS Quick Start Templates
# 9: Python 3.7
# 8: Python 3.7
# eb-app-maven: response to name
# 3: select event-bridge app from scratch
# Y: Use default profile
Expand All @@ -255,7 +255,7 @@ def test_init_interactive_with_event_bridge_app_non_supported_schemas_region(sel

user_input = """
1
9
8
eb-app-python37
3
Y
Expand Down