fix: Handle global value for Function CodeUri in Package #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to add tests, may have a refactoring pass as well. This is part of an effort to fix issue aws#1706
sanathkr
suggested changes
Jan 31, 2020
| resource_type = resource.get("Type", None) | ||
| resource_dict = resource.get("Properties", None) | ||
|
|
||
| if "CodeUri" not in resource and resource_type == AWS_SERVERLESS_FUNCTION: |
There was a problem hiding this comment.
The bug doesn't state, but DefinitionUri of Globals->Api also needs same treatment
There was a problem hiding this comment.
Will check this with the Layers issue as well.
|
Does Globals also support Layers? If so, that also will need to be added. |
|
I believe that Globals would indeed support layers. I'll look in to that. |
sanathkr
approved these changes
Jan 31, 2020
|
Sounds like Globals do not yet support Layers, so no-op there. |
This would actually be a gate for all possible global checks.
This was referenced Feb 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1706
Why is this change necessary?
The
sam packagecommand does not read any global values over the course of packaging - traditionally, only build and deploy functionality would use any values. Issue #1706 points to an uncommon use case that exposes that some global values do need to be considered, at minimum so that package won't break deploy.How does it address the issue?
Creates an
apply_global_valuesmethod that fetches global values we use (currently just the one) and applies them if/when they are applicable.What side effects does this change have?
None
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.