Efficient deploy log fetching #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sriram-mv
requested changes
Feb 6, 2020
| for event_items in response_iterator: | ||
| for event in event_items["StackEvents"]: | ||
| if event["EventId"] not in events and utc_to_timestamp(event["Timestamp"]) > time_stamp_marker: | ||
| events.add(event["EventId"]) | ||
| latest_time_stamp_marker = max( |
There was a problem hiding this comment.
I understand the logic here, could you add a unit test to showcase this?
There was a problem hiding this comment.
Thank you for the review!
I've added the unit test. Could you review it?
added 2 commits
February 8, 2020 21:03
In past logic, if the stack is newly created, time_stamp_marker would never be updated.
sriram-mv
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change necessary?
This PR improves
sam deployinefficient log fetching. Current implementation fetches events repeatidly until deploy finished. And it fetches "all" log events for every fetches. It includes already shown events and old events before the current deployment starts.So, when we update a stack in many times, sam-cli event showing becomes quite slow. And it takes a little bit longer time after actual stack deployment finished.
How does it address the issue?
The PR implementation skip older events and prevent to fetch all, old events.
What side effects does this change have?
I guess almost nothing. Maybe the number of API calls increases because it does not fetch all old events.
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.