-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: version bump on aws-lambda-builders to 0.7.0 #1771
Conversation
You need to update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any reason of not letting sam-cli to pick latest available minor version of lambda builders?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update the base.txt.
If this is the case, can we remove it from isolate.txt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isolated doesn't need to be updated but it's fine.
| Do we have any reason of not letting sam-cli to pick latest available minor version of lambda builders? To provide a better install experience. If we do not pin, we run the risk of a deployment of aws-lambda-builders impacting already released version of SAM CLI. Ideally, we should be pinning all of our dependencies, but we allow customers to use pip so we only do some of the dependencies instead (mainly ones we control). |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.