Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: version bump on aws-lambda-builders to 0.7.0 #1771

Merged
merged 2 commits into from Feb 4, 2020
Merged

chore: version bump on aws-lambda-builders to 0.7.0 #1771

merged 2 commits into from Feb 4, 2020

Conversation

awood45
Copy link
Member

@awood45 awood45 commented Feb 4, 2020

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@awood45 awood45 requested a review from jfuss February 4, 2020 17:58
@jfuss
Copy link
Contributor

jfuss commented Feb 4, 2020

You need to update base.txt not isolated.

c2tarun
c2tarun approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@c2tarun c2tarun left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any reason of not letting sam-cli to pick latest available minor version of lambda builders?

jfuss
jfuss requested changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@jfuss jfuss left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the base.txt.

@c2tarun
Copy link
Contributor

c2tarun commented Feb 4, 2020

Ned to update the base.txt.

If this is the case, can we remove it from isolate.txt?

jfuss
jfuss approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@jfuss jfuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isolated doesn't need to be updated but it's fine.

@jfuss
Copy link
Contributor

jfuss commented Feb 4, 2020

| Do we have any reason of not letting sam-cli to pick latest available minor version of lambda builders?

To provide a better install experience. If we do not pin, we run the risk of a deployment of aws-lambda-builders impacting already released version of SAM CLI. Ideally, we should be pinning all of our dependencies, but we allow customers to use pip so we only do some of the dependencies instead (mainly ones we control).

@awood45 awood45 merged commit ca6dfb8 into aws:develop Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c2tarun c2tarun c2tarun approved these changes

@jfuss jfuss jfuss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@awood45 @jfuss @c2tarun