fix: display no outputs if outputs are not defined. #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c2tarun
approved these changes
Feb 12, 2020
sanathkr
suggested changes
Feb 12, 2020
samcli/lib/deploy/deployer.py
Outdated
| @@ -401,7 +401,8 @@ def wait_for_execute(self, stack_name, changeset_type): | |||
| raise deploy_exceptions.DeployFailedError(stack_name=stack_name, msg=str(ex)) | |||
|
|
|||
| outputs = self.get_stack_outputs(stack_name=stack_name, echo=False) | |||
| self._stack_outputs(outputs) | |||
| if outputs: | |||
| self._stack_outputs(outputs) | |||
There was a problem hiding this comment.
should this be given a more descriptive name? When I saw this code in your old PR, I thought it was functional - turns out this is just cosmetic.
There was a problem hiding this comment.
yeah true, I'll change it to display stack outputs.
Why is this change necessary? * bug from previous PR which always looked for outputs in deployed templates. How does it address the issue? * Explicitly check for outputs, before attempting to display them. * Added extra tests to verify so that it does not cause regressions in the future. What side effects does this change have? * None.
sriram-mv
force-pushed
the
outputs-bug-fix
branch
from
0581d40
to
2f04eb5
Compare
sanathkr
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change necessary?
templates.
How does it address the issue?
the future.
What side effects does this change have?
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.