test: run by canary #1793
Merged
test: run by canary #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sriram-mv
requested changes
Feb 12, 2020
tests/testing_utils.py
Outdated
| @@ -8,6 +8,7 @@ | |||
| RUNNING_ON_CI = os.environ.get("APPVEYOR", False) | |||
| RUNNING_TEST_FOR_MASTER_ON_CI = os.environ.get("APPVEYOR_REPO_BRANCH", "master") != "master" | |||
| CI_OVERRIDE = os.environ.get("APPVEYOR_CI_OVERRIDE", False) | |||
| RUN_BY_CANARY = os.environ.get("BY_CANARY", None) is not None | |||
There was a problem hiding this comment.
Can we follow similar convention here? We say False on the rest.
sriram-mv
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Why is this change necessary?
Working on creating Canary to run all integration tests in secure environment. This code change disable skipping test if tests are triggered by Canary.
How does it address the issue?
Canary Trigger will setup an environment variable which will be monitored by tests. If detected then this will disable skipping tests.
What side effects does this change have?
None
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.