Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ruby2.7 support in AWS SAM CLI #1806

Merged
merged 2 commits into from
Feb 20, 2020
Merged

feat: ruby2.7 support in AWS SAM CLI #1806

merged 2 commits into from
Feb 20, 2020

Conversation

sriram-mv
Copy link
Contributor

Why is this change necessary?

  • To support ruby2.7 runtime in AWS SAM CLI.

How does it address the issue?

  • sam init, sam build , sam local are all supported for ruby2.7

What side effects does this change have?

  • None

Issue #, if available:

Why is this change necessary?

How does it address the issue?

What side effects does this change have?

Checklist:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Why is this change necessary?

* To support ruby2.7 runtime in AWS SAM CLI.

How does it address the issue?

* `sam init`, `sam build` , `sam local` are all supported for ruby2.7

What side effects does this change have?

* None
@sriram-mv sriram-mv requested a review from jfuss February 19, 2020 22:23
Copy link
Contributor

@jfuss jfuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We will need to update the ruby template in our template's repo as well

@sriram-mv
Copy link
Contributor Author

Yes: aws/aws-sam-cli-app-templates#20 covers that.

@jfuss jfuss merged commit 88bc1a3 into aws:develop Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants