Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode special characters when generating events #216

Closed
wants to merge 2 commits into from
Closed

Encode special characters when generating events #216

wants to merge 2 commits into from

Conversation

mariusgrigaitis
Copy link

Solves #214

@LuckyStubs LuckyStubs mentioned this pull request Feb 16, 2018
Closed
@PaulMaddox
Copy link
Contributor

I'm going to hold off merging this, as I think there needs to be a more general solution for encoding of data for all events, not just SNS.

I also think the whole way events are generated at the moment needs an overhaul.

@sanathkr
Copy link
Contributor

This PR hasn't gotten traction. Closing now. Feel free to re-submit if you plan on working on it.

@sanathkr sanathkr closed this May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owlies-huayu owlies-huayu owlies-huayu approved these changes

@LuckyStubs LuckyStubs LuckyStubs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mariusgrigaitis @PaulMaddox @sanathkr @owlies-huayu @LuckyStubs