Fix: Missing Unix Permission Bits for Artifact ZIP Created in Windows #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoshUS
changed the title
jfuss
requested changes
Sep 1, 2020
6 tasks
aahung
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR:
#1986
Issue:
#954
Why is this change necessary?
ZIP created in Windows will have no Unix permission bits and host OS is set to Windows.
When unzipping in Unix system, like lambda function, permission is set to default 0666.
How does it address the issue?
Lambda function needs execution permission bit set for "global/other".
Permission bits will be set to 0755 in Windows.
Host OS will also be changed to Unix so the permission will be preserved while unzipping.
What side effects does this change have?
All artifact ZIP files created in Windows will be have 0755 permission.
Did you change a dependency in
requirements/base.txt?No
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.