fix: create signer client with region definition #2455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prenx4x
approved these changes
Dec 4, 2020
jfuss
approved these changes
Dec 7, 2020
Good point. Added some unit tests for client creation of |
mndeveci
added a commit
to mndeveci/aws-sam-cli
that referenced
this pull request
Jan 19, 2021
* fix: create signer client with region definition * chore: black formatting * chore: add unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
#2433
Why is this change necessary?
If user doesn't have any default region setting (env variable or in ~/.aws folder) guided deploy command will fail.
How does it address the issue?
This change sets region from guided deploy parameters
What side effects does this change have?
None
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.