fix: Value of QueryString in the API event should only be a string #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the bug reported in aws#404
sanathkr
reviewed
May 31, 2018
| Empty dict if no query params where in the request otherwise returns a dictionary of key to value | ||
|
|
||
| """ | ||
| query_string_dict = {} |
There was a problem hiding this comment.
nit: Most variables in this method are named query_string_<type> or some flavor of it. This is not descriptive. You don't need the prefix because you are inside a method that processes query string parameters
sanathkr
approved these changes
May 31, 2018
| # Flask returns an ImmutableMultiDict so convert to a dictionary that becomes | ||
| # a dict(str: list) then iterate over | ||
| for query_string_key, query_string_list in dict(flask_request.args).items(): | ||
| query_string_value_length = len(query_string_list) |
There was a problem hiding this comment.
nit: This variable is unnecessary. You can just do if query_string_listto know if the list is empty or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug reported in #404
Issue #, if available: #404
Description of changes:
APIGW only supports one value for a query string key. 0.3.0 assumed this was a list. This PR aligns the Event that is sent to Lambda on a request with how APIGW handles Query Strings.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.