Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conflict test case #4306

Merged
merged 1 commit into from Oct 14, 2022
Merged

Remove conflict test case #4306

merged 1 commit into from Oct 14, 2022

Conversation

xazhao
Copy link
Contributor

@xazhao xazhao commented Oct 14, 2022

Which issue(s) does this change fix?

Canary integration tests failed.

Why is this change necessary?

Two integration tests shares the same OIDC identity provider however only the first test to run will create it. But we don't have control which one will run first. And the other test with create image has been tested in other test cases. Hence remove it.

How does it address the issue?

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hawflau hawflau merged commit 8616e18 into aws:develop Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants