Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Clarify note about code building on sam local start-api #4423

Merged
merged 6 commits into from Nov 18, 2022
Merged

chore: Clarify note about code building on sam local start-api #4423

merged 6 commits into from Nov 18, 2022

Conversation

yuyokk
Copy link
Contributor

@yuyokk yuyokk commented Nov 16, 2022

Hi team,

Running code locally with sam local start-api and see this message

You can now browse to the above endpoints to invoke your functions. You do not need to restart/reload SAM CLI while working on your functions, changes will be reflected instantly/automatically. You only need to restart SAM CLI if you update your AWS SAM template

I assumed (similar to what was described here #901 and #1921) that my typescript code will be built as well but it is not the case.

Thought of clarifying this in the text of that note.

Please let me know if this makes sense.

Thank you

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yuyokk yuyokk requested a review from a team as a code owner November 16, 2022 21:35
@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Nov 16, 2022
@yuyokk yuyokk changed the title Clarify note about code building on sam local start-api chore: Clarify note about code building on sam local start-api Nov 16, 2022
mildaniel
mildaniel reviewed Nov 16, 2022
View reviewed changes
Copy link
Contributor

@mildaniel mildaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this up! It's a great user experience improvement to have more accurate messaging! Left a small comment to discuss some of the wording.

samcli/commands/local/lib/local_api_service.py Outdated Show resolved Hide resolved
@mildaniel mildaniel added area/local/invoke sam local invoke command area/local/start-api sam local start-api command and removed stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. area/local/invoke sam local invoke command labels Nov 16, 2022
@mildaniel mildaniel merged commit c181449 into aws:develop Nov 18, 2022
@mildaniel
Copy link
Contributor

Thank you @yuyokk for your contribution!

@yuyokk yuyokk deleted the clarify-note-on-building branch November 18, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mndeveci mndeveci mndeveci approved these changes

@mildaniel mildaniel mildaniel approved these changes

@moelasmar moelasmar Awaiting requested review from moelasmar moelasmar is a code owner automatically assigned from aws/serverless-application-experience-sbt

@hnnasit hnnasit Awaiting requested review from hnnasit hnnasit is a code owner automatically assigned from aws/serverless-application-experience-sbt

Assignees
No one assigned
Labels
area/local/start-api sam local start-api command pr/external
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yuyokk @mildaniel @mndeveci