feat(Python3): Build support for Python3.6 #478
Conversation
|
I couldn't seem to get If you have a better idea on something else I should be doing to make these work, I am happy to address and give it a try. |
| @@ -101,7 +101,7 @@ Prerequisites | |||
| ~~~~~~~~~~~~~ | |||
|
|
|||
| - Docker | |||
| - Python2.7 (Python3+ not yet supported) | |||
| - Python2.7 or Python3.6 | |||
README.rst
Outdated
| @@ -253,7 +253,7 @@ homebrew and try again: | |||
|
|
|||
| .. code:: bash | |||
|
|
|||
| brew install python@2 | |||
| brew install python@3 | |||
There was a problem hiding this comment.
remove the version identifier here.
| self.obj_to_patch = obj_to_patch | ||
|
|
||
| def __enter__(self): | ||
| self.obj_to_patch.warning = self.warning |
There was a problem hiding this comment.
wow! Something to live with until SAM Translator makes a new release.
| @@ -16,6 +17,8 @@ | |||
| from samcli.commands.local.lib.local_lambda import LocalLambdaRunner | |||
| from samcli.local.docker.manager import ContainerManager | |||
|
|
|||
| logging.getLogger().setLevel(logging.DEBUG) | |||
There was a problem hiding this comment.
Can you remove this line?
tox.ini
Outdated
| commands = make pr | ||
| commands = | ||
| make pr | ||
| passenv = * |
There was a problem hiding this comment.
:( I couldn't get for some reason and forgot to removed.
This reverts commit b6308c8ab8ee20ec53134f6537ce84f95580036d.
…st_must_fail_on_download_from_s3
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.