Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update commands to upload test reports to narrow filtering #4808

Merged
merged 2 commits into from Mar 3, 2023

Conversation

hawflau
Copy link
Contributor

@hawflau hawflau commented Mar 3, 2023

Which issue(s) does this change fix?

Why is this change necessary?

The include filter in aws s3 cp commands in Windows appveyor jobs are including the json files in the tests/ directory, which is inconsistent with what we've seen in the Linux appveyor jobs.

How does it address the issue?

Apply a stricter include filter

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hawflau hawflau requested a review from a team as a code owner March 3, 2023 04:25
@hawflau hawflau merged commit 0268e8f into aws:develop Mar 3, 2023
@hawflau hawflau deleted the move-test-reports branch March 3, 2023 19:42
mildaniel pushed a commit to mildaniel/aws-sam-cli that referenced this pull request Mar 3, 2023
mildaniel added a commit that referenced this pull request Mar 4, 2023
* test: Configure end-to-end tests in canaries

* Fixed init schema integration tests (#4803)

* test: end-to-end test suite (#4788)

* test: end-to-end test suite

* Add remaining stages

* Refactor to have test cases control assertions

* Make validators their own class

* Black reformat

* Pass down test context instead of changing dir

* Run in parallel, lock init execution

* bug: Allow re-use of poll delay env variable on wait changeset (#4729)

* Use sam cli poll delay env for waiting on changeset

* Add unit test to validate env is variable is passed properly

* Add additional test to test delay

* Set delay to client sleep by default

* Fix formatting

---------

Co-authored-by: Sriram Madapusi Vasudevan <3770774+sriram-mv@users.noreply.github.com>
Co-authored-by: Jacob Fuss <32497805+jfuss@users.noreply.github.com>

* Update commands to upload test reports to narrow filtering (#4808)

* Black reformat

---------

Co-authored-by: hnnasit <84355507+hnnasit@users.noreply.github.com>
Co-authored-by: Sai Tirumerla <57160285+tirumerla@users.noreply.github.com>
Co-authored-by: Sriram Madapusi Vasudevan <3770774+sriram-mv@users.noreply.github.com>
Co-authored-by: Jacob Fuss <32497805+jfuss@users.noreply.github.com>
Co-authored-by: Wing Fung Lau <4760060+hawflau@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants