Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use relative path when resolving nested stack location #4871

Merged
merged 6 commits into from Mar 22, 2023

Conversation

mndeveci
Copy link
Contributor

@mndeveci mndeveci commented Mar 15, 2023

Which issue(s) does this change fix?

N/A

Why is this change necessary?

When resolving location of the nested stack template in InfraSyncExecutor, it should resolve relative to the parent template which is referencing to the nested one.

How does it address the issue?

It resolves by prepending parent folder of the current template.

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mndeveci mndeveci marked this pull request as ready for review March 16, 2023 00:23
@mndeveci mndeveci requested a review from a team as a code owner March 16, 2023 00:23
@mndeveci mndeveci added this pull request to the merge queue Mar 22, 2023
@mndeveci mndeveci merged commit ab6a70c into aws:develop Mar 22, 2023
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants