New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: respect --resolve-s3
and --resolve-image-repos
in a guided context.
#4873
Conversation
Tests fixed. |
* especially when --resolve-s3 or --resolve-image-repos is set, no further questions are asked on setting up infrastructure.
c6f1490
to
83e6b07
Compare
--resolve-s3
and --resolve-image-repos
in a guided context.
self.guided_image_repositories = image_repositories | ||
# NOTE(sriram-mv): The resultant s3 bucket is ALWAYS the managed_s3_bucket. There is no user flow to set it | ||
# within guided. | ||
self.resolve_s3 = True if self.guided_s3_bucket else False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very much a nit comment and might be more on the side of personal preference 😄
self.resolve_s3 = True if self.guided_s3_bucket else False | |
self.resolve_s3 = bool(self.guided_s3_bucket) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Do we need to make sure integration test are succeeding, since this might change the output and input prompts there?
@mndeveci : I ran all the deploy integration tests locally and they succeeded. |
Which issue(s) does this change fix?
#4841
Why is this change necessary?
sam deploy --guided
and continue to runsam deploy
afterwards without running into issues where--resolve-s3
and--s3-bucket
are both set.How does it address the issue?
--resolve-s3
and--resolve-image-repos
What side effects does this change have?
sam deploy --guided --s3-bucket <> or sam deploy --guided --image-repositories <>
will ignore the bucket or the image repositories as it is the managed flow.Mandatory Checklist
PRs will only be reviewed after checklist is complete
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.