Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: skip infra sync for SAM Accelerate #4883

Merged
merged 18 commits into from Mar 23, 2023
Merged

feat: skip infra sync for SAM Accelerate #4883

merged 18 commits into from Mar 23, 2023

Conversation

mndeveci
Copy link
Contributor

@mndeveci mndeveci commented Mar 17, 2023 •
edited

Enables Skip Infra Sync feature for SAM Accelerate & adds integration tests for it.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mndeveci mndeveci changed the title [DO NOT MERGE] feat: skip infra sync for sam sync [DO NOT MERGE] feat: skip infra sync for SAM Accelerate Mar 17, 2023
mndeveci and others added 16 commits March 20, 2023 15:10
@mndeveci
Merge branch 'develop' into skip_infra
6957b16
@hnnasit
Merge branch 'develop' into skip_infra
b70d59c
@hnnasit
Made skip-deploy-sync flag visible and uncommented/updated unit tests
21946df
@hnnasit
Merge branch 'skip_infra' into skip-infra-ga-pr
626dcac
@hnnasit
Run make black
6268e00
@hnnasit
Make skip-deploy-sync flag visible and uncomment/update unit tests
7c41afd
@hnnasit
Added telemetry event tracking for infra-sync and when infra sync is …
95ab1b5 
…skipped
@hnnasit
Change the name of telemetry events
49e3f24
@hnnasit
Add telemetry event tracking for infra-sync and when infra sync is sk…
0b75c82 
…ipped
@hnnasit
Merge branch 'develop' into skip_infra
1c2dd48
@mndeveci
Merge branch 'develop' into skip_infra
174cccc
@qingchm
Update skip integration test to include more resources and nested stack
b88af64
@qingchm
Change cwd for sync tests to use test dir
578336e
@qingchm
Remove the skip windows condition for skip infra tests
ae0d172
@qingchm
Merge pull request #5 from qingchm/skip_infra_integration
59fc6fa 
chore: Skip infra integration tests
@mndeveci
Merge branch 'develop' into skip_infra
2087a8f
@mndeveci mndeveci changed the title [DO NOT MERGE] feat: skip infra sync for SAM Accelerate feat: skip infra sync for SAM Accelerate Mar 22, 2023
@mndeveci mndeveci marked this pull request as ready for review March 22, 2023 23:39
@mndeveci mndeveci requested a review from a team as a code owner March 22, 2023 23:39
@mndeveci mndeveci enabled auto-merge March 22, 2023 23:40
@mndeveci mndeveci added this pull request to the merge queue Mar 23, 2023
@mndeveci mndeveci merged commit aaa120d into aws:develop Mar 23, 2023
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingchm qingchm qingchm approved these changes

@hnnasit hnnasit hnnasit approved these changes

@mildaniel mildaniel Awaiting requested review from mildaniel mildaniel is a code owner automatically assigned from aws/serverless-application-experience-sbt

Assignees
No one assigned
Labels
pr/internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mndeveci @qingchm @hnnasit