Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add python3.10 support #4898

Merged
merged 4 commits into from Mar 21, 2023
Merged

feat: add python3.10 support #4898

merged 4 commits into from Mar 21, 2023

Conversation

mndeveci
Copy link
Contributor

@mndeveci mndeveci commented Mar 21, 2023 •
edited

Adding python3.10 support for sam local and sam build commands.

sam package command will emit a warning, if a stack with a python3.10 function is being packaged.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

briensea and others added 2 commits March 21, 2023 00:11
@briensea @mndeveci
feat: add python3.10 support. (aws#434)
f38af28 
* Add python3.10 support.

* Add python3.10 enum.

* add preview runtiem warning message during package

* update warning message after UX sync

* Update warning message when attempting to use non-GA runtimes.

* Update wording in warning message when deploying non GA runtimes.

* formatting

---------

Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>
@mndeveci
Merge branch 'develop' into feat-python3.10
e832cf7
@github-actions github-actions bot added pr/internal area/build sam build command area/local/invoke sam local invoke command area/local/start-api sam local start-api command area/local/start-invoke area/package sam package command labels Mar 21, 2023
@mndeveci mndeveci marked this pull request as ready for review March 21, 2023 07:19
@mndeveci mndeveci requested a review from a team as a code owner March 21, 2023 07:19
@mndeveci mndeveci changed the title feat: add python3.10 support. (#434) feat: add python3.10 support Mar 21, 2023
@mndeveci mndeveci enabled auto-merge March 21, 2023 22:01
@mndeveci mndeveci added this pull request to the merge queue Mar 21, 2023
@mndeveci mndeveci merged commit 43df006 into aws:develop Mar 21, 2023
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawflau hawflau hawflau approved these changes

@moelasmar moelasmar moelasmar approved these changes

@mildaniel mildaniel Awaiting requested review from mildaniel mildaniel is a code owner automatically assigned from aws/serverless-application-experience-sbt

@hnnasit hnnasit Awaiting requested review from hnnasit hnnasit is a code owner automatically assigned from aws/serverless-application-experience-sbt

Assignees
No one assigned
Labels
area/build sam build command area/local/invoke sam local invoke command area/local/start-api sam local start-api command area/local/start-invoke area/package sam package command pr/internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mndeveci @hawflau @moelasmar @briensea