Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update preview runtime warning message and add missing py310 tests #4908

Merged
merged 5 commits into from Mar 23, 2023

Conversation

mndeveci
Copy link
Contributor

Which issue(s) does this change fix?

N/A

Why is this change necessary?

  • When collecting all functions in a template, SamFunctionProvider has side affects which fails during collection of layers.
  • python3.10 was missing in-process build tests

How does it address the issue?

  • By checking the resources dictionaries rather than collecting them with provider above.
  • python3.10 tests are added into parameterized test annotation

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mndeveci mndeveci requested a review from a team as a code owner March 22, 2023 21:38
@github-actions github-actions bot added pr/internal area/package sam package command labels Mar 22, 2023
@mndeveci mndeveci enabled auto-merge March 22, 2023 22:04
@mndeveci mndeveci added this pull request to the merge queue Mar 23, 2023
@mndeveci mndeveci merged commit ca5606e into aws:develop Mar 23, 2023
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/package sam package command pr/internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants