Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update remote invoke context to actually invoke the executor #5193

Merged
merged 5 commits into from
May 24, 2023

Conversation

mndeveci
Copy link
Contributor

@mndeveci mndeveci commented May 23, 2023

Updates RemoteInvokeContext object to invoke the remote invoke executor;

  • Updated __enter__ method to find resource summary for given stack name and resource logical id
  • Implemented run method, to instantiate remote invoke executor through its factory and run execute method on it
  • Updated get_resource_summary in CFN utilities to return resources from nested stacks.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mndeveci mndeveci marked this pull request as ready for review May 24, 2023 19:52
@mndeveci mndeveci requested a review from a team as a code owner May 24, 2023 19:52
@mndeveci mndeveci requested review from lucashuy and jfuss May 24, 2023 19:52
Copy link
Contributor

@sriram-mv sriram-mv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hnnasit hnnasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Left a small comment.

@mndeveci mndeveci enabled auto-merge May 24, 2023 20:40
@mndeveci mndeveci added this pull request to the merge queue May 24, 2023
Merged via the queue into aws:develop with commit a273c94 May 24, 2023
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants