Accessibility and help text changes #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanathkr
approved these changes
Jul 13, 2018
heitorlessa
added a commit
to heitorlessa/aws-sam-cli
that referenced
this pull request
Jul 21, 2018
* develop: docs: Fix @mhart link in README (aws#562) docs: Change jest to mocha in Nodejs init README (aws#564) docs: Fix syntax highlighting in README.md (aws#561) fix: spacing typo in Log statement in start-lambda (aws#559) fix: Functional tests must run on localhost to work in Windows (aws#552) docs: Adding readme for "sam logs" and "sam local start-lambda" command (aws#557) docs: Accessibility and help text changes (aws#554) chore: Preparing for release - v0.5.0 (aws#553) feat(LocalLambdaService): Integ test for start-lambda command (aws#550)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Discovered an accessibility issue where the logs weren't visible if the background was light. Fixed that by removing the color so the output defaults to the system color. Tested that this works on both light and dark backgrounds.
Also changed phrasing on a few commands and added examples in the help text for a few new commands. Tested these updates by previewing the output.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.