Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of non-json-deserializable response from RIE #5881

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

hawflau
Copy link
Contributor

@hawflau hawflau commented Sep 2, 2023

Which issue(s) does this change fix?

#5799

Why is this change necessary?

In some rare occasion, RIE response cannot be deserialized by json.loads, resulting in JSONDecodeError

How does it address the issue?

Handle JSONDecodeError, and update stdout to write response with write_str or write_bytes based on response type.

What side effects does this change have?

No

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hawflau hawflau marked this pull request as ready for review September 2, 2023 02:41
@hawflau hawflau requested a review from a team as a code owner September 2, 2023 02:41
@hawflau hawflau added this pull request to the merge queue Sep 5, 2023
Merged via the queue into aws:develop with commit 206f868 Sep 5, 2023
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants