fix: copy resource metadata before normalizing the information in it #5904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sriram-mv
requested changes
Sep 8, 2023
| @@ -456,6 +457,53 @@ def test_skip_normalizing_already_normalized_resource(self): | |||
| self.assertEqual("new path", template_data["Resources"]["Function1"]["Properties"]["Code"]) | |||
| self.assertEqual("Function1", template_data["Resources"]["Function1"]["Metadata"]["SamResourceId"]) | |||
|
|
|||
| def test_referenced_data(self): | |||
There was a problem hiding this comment.
Where are we asserting based on the new changes?
There was a problem hiding this comment.
Before this change, SamResourceId is assigned as FirstFunction for all resources due to the reason I explained in the PR desc.
After this change, all resources must have their logical id assigned into SamResourceId, we are asserting them at the end of this changed block.
There is a redundant function that I forgot to remove, please ignore that, will be removing it now.
sriram-mv
approved these changes
Sep 14, 2023
lucashuy
approved these changes
Sep 14, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
#5901
Why is this change necessary?
When using value references in yaml file, the objects that is been created are the same instance. For that reason, changing one value from one instance will also affect the other instances.
The behaviour above causes issues when updating/normalizing resource metadata information. With that, we are adding
SamResourceIdinformation, but ifMetadatainformation is been shared between resources, then it updates for all of them, which creates issues down the road when we are extracting functions.How does it address the issue?
This change copies metadata before starting changes, and assigns it back once it is finalized, so that it won't affect all of the references.
What side effects does this change have?
N/A
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.