Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Clean up test data folder between runs #5925

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

lucashuy
Copy link
Contributor

Which issue(s) does this change fix?

None.

Why is this change necessary?

Testing folder and data was not being cleaned between test runs if the test were to fail and be retried.

How does it address the issue?

Updates the set up and tear down methods of the test watch base class to delete the contents of the previous test run before restarting the test.

What side effects does this change have?

None.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lucashuy lucashuy marked this pull request as ready for review September 12, 2023 16:57
@lucashuy lucashuy requested a review from a team as a code owner September 12, 2023 16:57
@lucashuy lucashuy added this pull request to the merge queue Sep 12, 2023
Merged via the queue into aws:develop with commit 88b1888 Sep 12, 2023
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants