-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Invoke stderr stream missing stack trace #5972
fix: Invoke stderr stream missing stack trace #5972
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this issue! LGTM in general, left a small comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me.
Please add a comment in the code which draws attention to this change with something like "Important! DO NOT CHANGE", and an explanation of why. Because the decode, encode can seem like weird behavior.
…/aws-sam-cli into fix-invoke-stack-trace-logging
Which issue(s) does this change fix?
N/A
Why is this change necessary?
After updating
sam local
commands to use the RIE in version 1.13.1, when a stack trace is streamed from the emulation container it contains carriage return characters that then don't get displayed by the stream writer.How does it address the issue?
Replaces the carriage return characters with the system's linesep character.
What side effects does this change have?
Will display addition logs when using local invoke commands that contain a stack trace.
Before:
After:
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.