Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(generate-event): SubCommand help text to be short-text. #652

Merged
merged 3 commits into from Sep 7, 2018

Conversation

jfuss
Copy link
Contributor

@jfuss jfuss commented Sep 4, 2018

The help text for the SubCommands in generate-event were getting truncated
in the terminal. The help text being displayed was the short_help text and not
the full text. If a click command does not have short_text assoicated, click
will truncate the help text to 45 characters. We will now set the short_text
to be the full text to allow the contents to be displayed on the screen.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The help text for the SubCommands in generate-event were getting truncated
in the terminal. The help text being displayed was the short_help text and not
the full text. If a click command does not have short_text assoicated, click
will truncate the help text to 45 characters.  We will now set the short_text
to be the full text to allow the contents to be displayed on the screen.
@sriram-mv
Copy link
Contributor

👍

Copy link
Contributor

@sanathkr sanathkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy fix!

@sanathkr sanathkr merged commit 2f08ba6 into aws:develop Sep 7, 2018
@sriram-mv sriram-mv mentioned this pull request Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants