Properly test results with generated Nodejs8.10 runtime unit tests. #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nodejs8.10 lambda doesn't take in a callback so tests pass no matter what. Should be testing results captured from await call.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodejs8.10 lambda doesn't take in a callback so tests pass no
matter what. Should be testing results captured from await call.
Issue #, if available:
Description of changes:
Nodejs 8.10 runtime unit tests are passing but not properly testing anything since the lamdba uses async/await instead of callbacks.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.