Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove dependency on pystache #684

Merged
merged 2 commits into from
Sep 28, 2018
Merged

fix: remove dependency on pystache #684

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
557b1a6
fix: remove dependency on pystache
sriram-mv Sep 27, 2018
8311647
fix: use non-patched version of chevron
sriram-mv Sep 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements/base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
six~=1.11.0
chevron~=0.12.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use the patch version. ~=0.12.2 implies >=0.12 and <0.13. So we want ~=0.12.

click~=6.7
enum34~=1.1.6; python_version<"3.4"
Flask~=1.0.2
Expand All @@ -10,5 +11,4 @@ docker>=3.3.0
dateparser~=0.7
python-dateutil~=2.6
pathlib2~=2.3.2; python_version<"3.4"
pystache~=0.5

3 changes: 1 addition & 2 deletions samcli/commands/local/lib/generated_sample_events/events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import base64
from requests.utils import quote

import pystache
from chevron import renderer


class Events(object):
Expand Down Expand Up @@ -126,5 +126,4 @@ def generate_event(self, service_name, event_type, values_to_sub):
data = json.dumps(data, indent=2)

# return the substituted file
renderer = pystache.Renderer()
return renderer.render(data, values_to_sub)