Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sam Commands Understand Local File Paths for AWS::Serverless::Function.ImageUri #6930

Merged
merged 12 commits into from
May 1, 2024

Commits on Apr 11, 2024

  1. feat: sam Commands Understand Local File Paths for ImageUri

    As a summary, sam has learned to load an an image from a local archive
    before proceeding with the `build`, `package`, and `deploy` commands.
    
    When running `sam build` with an `ImageUri` pointing to a local file,
    sam will load that archive into an image, then write the ID of the
    image to the `ImageUri` property of the built template. ID works the
    same as a tag for the Docker API, so business continues as usual from
    here. The reason behind writing ID is that a loaded image could be
    associated with multiple tags, and selecting one arbtrarily leads to
    difficulties in the deploy command.
    
    The package and deploy commands have three kinds of value for
    `ImageUri` to consider. First, a value of the form
    `{repo}:{tag}`. This functions as it always has. Second, an image
    ID (in the form `sha256:{digest}`) which is probably the output of
    `sam build`. In this case, the tag translation uses the name of the
    as its input. Otherwise, they'd all end up with names starting with
    "sha256". Last, a local file. In this case, it proceeds as it does in
    the build command: Load the archive into an image first, then pass the
    resource name into tag translation.
    
    See: aws#6909
    chrisoverzero committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    af5336b View commit details
    Browse the repository at this point in the history
  2. Reword Explanatory Comment

    chrisoverzero committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    b3a2c56 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    75136ff View commit details
    Browse the repository at this point in the history
  4. Take a Swing at Unit Tests

    chrisoverzero committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    e38215a View commit details
    Browse the repository at this point in the history
  5. Cover Another Test Case

    chrisoverzero committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    a83de54 View commit details
    Browse the repository at this point in the history
  6. Take a Swing at Integration Tests

    Also, genericize unit tests a little.
    
    See: aws#6909
    chrisoverzero committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    4c3f4b8 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Configuration menu
    Copy the full SHA
    642213c View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Configuration menu
    Copy the full SHA
    4a5efc7 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Configuration menu
    Copy the full SHA
    98bbbcc View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Configuration menu
    Copy the full SHA
    33dc05f View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. Configuration menu
    Copy the full SHA
    9d65e81 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Configuration menu
    Copy the full SHA
    b6e84d4 View commit details
    Browse the repository at this point in the history