-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sam Commands Understand Local File Paths for AWS::Serverless::Function.ImageUri
#6930
Merged
sidhujus
merged 12 commits into
aws:develop
from
chrisoverzero:feat/imageuri-as-image-archive
May 1, 2024
Merged
feat: sam Commands Understand Local File Paths for AWS::Serverless::Function.ImageUri
#6930
sidhujus
merged 12 commits into
aws:develop
from
chrisoverzero:feat/imageuri-as-image-archive
May 1, 2024
Commits on Apr 11, 2024
-
feat: sam Commands Understand Local File Paths for
ImageUri
As a summary, sam has learned to load an an image from a local archive before proceeding with the `build`, `package`, and `deploy` commands. When running `sam build` with an `ImageUri` pointing to a local file, sam will load that archive into an image, then write the ID of the image to the `ImageUri` property of the built template. ID works the same as a tag for the Docker API, so business continues as usual from here. The reason behind writing ID is that a loaded image could be associated with multiple tags, and selecting one arbtrarily leads to difficulties in the deploy command. The package and deploy commands have three kinds of value for `ImageUri` to consider. First, a value of the form `{repo}:{tag}`. This functions as it always has. Second, an image ID (in the form `sha256:{digest}`) which is probably the output of `sam build`. In this case, the tag translation uses the name of the as its input. Otherwise, they'd all end up with names starting with "sha256". Last, a local file. In this case, it proceeds as it does in the build command: Load the archive into an image first, then pass the resource name into tag translation. See: aws#6909
Configuration menu - View commit details
-
Copy full SHA for af5336b - Browse repository at this point
Copy the full SHA af5336bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b3a2c56 - Browse repository at this point
Copy the full SHA b3a2c56View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75136ff - Browse repository at this point
Copy the full SHA 75136ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for e38215a - Browse repository at this point
Copy the full SHA e38215aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a83de54 - Browse repository at this point
Copy the full SHA a83de54View commit details -
Take a Swing at Integration Tests
Also, genericize unit tests a little. See: aws#6909
Configuration menu - View commit details
-
Copy full SHA for 4c3f4b8 - Browse repository at this point
Copy the full SHA 4c3f4b8View commit details
Commits on Apr 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 642213c - Browse repository at this point
Copy the full SHA 642213cView commit details
Commits on Apr 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4a5efc7 - Browse repository at this point
Copy the full SHA 4a5efc7View commit details
Commits on Apr 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 98bbbcc - Browse repository at this point
Copy the full SHA 98bbbccView commit details
Commits on Apr 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 33dc05f - Browse repository at this point
Copy the full SHA 33dc05fView commit details
Commits on Apr 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9d65e81 - Browse repository at this point
Copy the full SHA 9d65e81View commit details
Commits on Apr 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b6e84d4 - Browse repository at this point
Copy the full SHA b6e84d4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.