Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct launch.json for node js debugging through vs code #704

Merged
merged 3 commits into from
Oct 12, 2018
Merged

fix: correct launch.json for node js debugging through vs code #704

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
feb726e
fix: correct launch.json for node js debugging through vs code
sriram-mv Oct 9, 2018
db6736b
refactor: node js debugging - launch.json
sriram-mv Oct 11, 2018
693bcdd
Merge branch 'develop' into nodejs_debug
jfuss Oct 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 17 additions & 15 deletions docs/usage.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,21 +308,23 @@ the following launch configuration:

.. code:: json

{
"version": "0.2.0",
"configurations": [
{
"name": "Attach to SAM CLI",
"type": "node",
"request": "attach",
"address": "localhost",
"port": 5858,
"localRoot": "${workspaceRoot}",
"remoteRoot": "/var/task",
"protocol": "legacy"
}
]
}
{
"version": "0.2.0",
"configurations": [{
"name": "Attach to SAM CLI",
"type": "node",
"request": "attach",
"address": "localhost",
"port": 5858,
"localRoot": "${workspaceRoot}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the ${workspaceRoot}/ right? This localRoot only works if you open the directory of the function code and not the whole project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes correct.

"sourceMapPathOverrides": {
"${workspaceRoot}/runtime": "${remoteRoot}"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you format the JSON here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely.

"remoteRoot": "/var/task",
"protocol": "inspector",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous protocol was legacy. What does updating this to inspector indicate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for newer version of nodejs, that is indicated right after in the readme, to swtich to legacy if you are using a older version of nodejs.

"stopOnEntry": false
}]
}

Note: Node.js versions --below-- 7 (e.g. Node.js 4.3 and Node.js 6.10)
use the ``legacy`` protocol, while Node.js versions including and above
Expand Down