Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update ruff params according to warning message #7060

Merged
merged 1 commit into from
May 13, 2024

Conversation

mndeveci
Copy link
Contributor

Which issue(s) does this change fix?

N/A

Why is this change necessary?

Running make lint is giving following warning message;

warning: `ruff <path>` is deprecated. Use `ruff check <path>` instead.
warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`:
  - 'ignore' -> 'lint.ignore'
  - 'select' -> 'lint.select'
  - 'pylint' -> 'lint.pylint'
  - 'per-file-ignores' -> 'lint.per-file-ignores'

How does it address the issue?

Updates ruff command and its configuration accordingly

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mndeveci mndeveci requested a review from a team as a code owner May 13, 2024 20:41
@mndeveci mndeveci requested review from hawflau and sidhujus May 13, 2024 20:41
@mndeveci mndeveci enabled auto-merge May 13, 2024 21:04
@mndeveci mndeveci added this pull request to the merge queue May 13, 2024
Merged via the queue into aws:develop with commit 4cd3c44 May 13, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants