Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch ResourceNotFound error when adding code trigger in sam sync #7245

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

hawflau
Copy link
Contributor

@hawflau hawflau commented Jul 12, 2024

Which issue(s) does this change fix?

#6873

Why is this change necessary?

If a Layer is set with a S3 Location, sam sync throws an error and stack trace when trying to add a code trigger for that layer. (Same for Lambda Function as well). This is due to the Layer/Function with a S3 Location is considered as ResourceNotFound from the create_trigger's perspective.

How does it address the issue?

In the caller (_add_code_triggers of WatchManager), catch ResourceNotFound and issue a warning.

example:

2024-07-12 09:09:07,876 | The resource AWS::Serverless::LayerVersion 'MyLayer' has specified S3 location for ContentUri. It will not be built and SAM CLI does not support invoking it locally.                                                                                                                                                  
2024-07-12 09:09:07,877 | CodeTrigger not created as MyLayer is not found or is with a S3 Location.  

What side effects does this change have?

No

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hawflau hawflau requested a review from a team as a code owner July 12, 2024 16:20
@hawflau hawflau requested review from hnnasit and sidhujus July 12, 2024 16:21
@hawflau hawflau added this pull request to the merge queue Jul 12, 2024
Merged via the queue into aws:develop with commit 07a3b50 Jul 12, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants