Making hello world java sample more idiomatic #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiiadi
force-pushed
the
update-hello-world
branch
from
0bcfac2
to
60adeb7
Compare
|
@kiiadi Did you run the tests within the init example with this change locally? |
|
@jfuss yes - I opened the cookie-cutter project in the IDE and ran it's unit tests after making the code-change. |
jfuss
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Updating the url fetcher to use try-with-resources and Stream collection to be more idiomatic with Java8
Testing:
Ran cookie-cutter unit tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.