What's up with PR reviews?

[blovlovski]

There are number of useful PRs sent by people around the world to this repo. Following the contribution guide, some contributors commented and requested reviews but it doesn't look like things are moving forward within reasonable time frame.

Namely:
#1342 was from march 2020 and even Git bot thinks it's deserted due to lack of response.
#1485, #1523, #1545 are getting conflicts. It's not reasonable to expect people to constantly rebase when there is no feedback.
#1541, #1506, developers requested review but no response.
All these PRs are from 2020.

Looking the backlog for this year,
#1562, #1572, #1643 are new feature addition that are well documented. No response.
#1595, #1606 are security/race fixes that seem very important. No response.
There are many other PRs that could use some love (even as small as fixing const-ness #1617 for god's sake). If something is not worth pursuing, why not just communicate to contributors instead of leaving people hanging?

Reviewers, please value the time and work people put in. I am calling this out after observing this issue for a long time, and hope it can be surfaced to relevant people on the aws team. If nobody can review PRs, please take down the contribution guideline section so nobody would waste more time contributing.

[ahmedyarub]

I just came here to ask the same question. I'm the author of #1562

[KaibaLopez]

Hi @blovlovski ,
Yes, you are right. I do a really poor job of responding to PRs and doing reviews, it's something I am trying to be better at.

I can't promise that I can get all of them but I'll try to get as many as I can addressed in the coming weeks, sorry again for the lack/slow responses.

[anatol]

@KaibaLopez could you please review/approve the fix for GCC11? #1506

[jmklix]

We have been working to address the PR's when they come in. Please let us know if we have missed your PR

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.