Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration file cannot be used with CMake 3.22.0 #1820

Closed
2 tasks done
ahmedyarub opened this issue Nov 26, 2021 · 3 comments
Closed
2 tasks done

Configuration file cannot be used with CMake 3.22.0 #1820

ahmedyarub opened this issue Nov 26, 2021 · 3 comments
Assignees
@KaibaLopez
Labels
bug This issue is a bug. pending-release This issue will be fixed by an approved PR that hasn't been released yet.

Comments

@ahmedyarub
Copy link

Confirm by changing [ ] to [x] below to ensure that it's a bug:

Describe the bug
There is a change in 3.22.0 reported here https://gitlab.kitware.com/cmake/cmake/-/issues/22524 which breaks AWSSDKConfig.cmake. A fix is already reported here #1810.

SDK version number
1.9.152

Platform/OS/Hardware/Device
All (Windows, Linux, MacOS, iOS, Android, and Emscripten)

To Reproduce (observed behavior)
1- Build and install SDK.
2- Use find_package() in a project that consumes the SDK.

Expected behavior
The SDK is imported and built without errors.

Logs/output
CMake Error at ...../AWSSDKConfig.cmake:128 (while):
had incorrect arguments:

"NOT" "TEMP_NAME" "STREQUAL"

Unknown arguments specified

To enable logging, set the following system properties:

REMEMBER TO SANITIZE YOUR PERSONAL INFO

options.loggingOptions.logLevel = Aws::Utils::Logging::LogLevel::Trace;
Aws::InitAPI(options)

Additional context
Add any other context about the problem here.
@ahmedyarub ahmedyarub added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 26, 2021
@ahmedyarub ahmedyarub mentioned this issue Nov 26, 2021
Merged
@KaibaLopez
Copy link
Contributor

Hi @ahmedyarub ,
Yea sorry for the delay getting this fix merged, I'll get to it. Thanks for the PR and the heads up.

@KaibaLopez KaibaLopez added pending-release This issue will be fixed by an approved PR that hasn't been released yet. and removed needs-triage This issue or PR still needs to be triaged. labels Nov 26, 2021
@KaibaLopez KaibaLopez self-assigned this Nov 26, 2021
LeonhardFS added a commit to LeonhardFS/tuplex-public that referenced this issue Nov 30, 2021
@LeonhardFS
restricting cmake to 3.21 because newer cmake 3.22 breaks aws sdk as …
22d73f0 
…reported in aws/aws-sdk-cpp#1820
@shahromil16 shahromil16 mentioned this issue Dec 4, 2021
Closed
2 tasks
LeonhardFS added a commit to tuplex/tuplex that referenced this issue Dec 6, 2021
@LeonhardFS
[FEATURE] Filesystem updates, add ls functionality for both Posix and…
c12cc68 
… S3 (#62)

Add list functionality to both Posix and AWS S3 VirtualFileSystems. Fixed Cmake to be 3.21 to avoid conflict with AWS SDK. Improve Lambda packaging.

Details:
- Fix S3 uri key/bucket extraction
- Add filesystem ls function for both Posix and AWS S3
- Fix permission to make zip package executable and changing mode to defalted
- Fix tuplex_runtime location in runner
- Add support for temp credentials in Lambda via session token
- Restrict cmake to 3.21 because newer cmake 3.22 breaks aws sdk as reported in aws/aws-sdk-cpp#1820
- Update lambda cost calculation

authored by: Leonhard Spiegelberg (leonhard@brown.edu)
@KaibaLopez
Copy link
Contributor

This change has been merged.
Thanks for the contribution!

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@kkraus14 kkraus14 mentioned this issue Feb 15, 2022
Closed
@ViridianMelody ViridianMelody mentioned this issue May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaibaLopez KaibaLopez

Labels
bug This issue is a bug. pending-release This issue will be fixed by an approved PR that hasn't been released yet.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KaibaLopez @ahmedyarub