Fix cspell workflow. #2010
Merged
Fix cspell workflow. #2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdavtaker
approved these changes
Jul 26, 2022
| @@ -71,7 +71,7 @@ namespace Aws | |||
|
|
|||
| enum class OverflowPolicy | |||
| { | |||
| QUEUE_TASKS_EVENLY_ACCROSS_THREADS, | |||
| QUEUE_TASKS_EVENLY_ACROSS_THREADS, | |||
There was a problem hiding this comment.
that's a backward incompatible change =(
There was a problem hiding this comment.
I know its either this or let it live mispelled forever, if someone is directly referencing this enum, then yes they will have to update it to the correct spelling.
SergeyRyabinin
approved these changes
Jul 26, 2022
jmklix
pushed a commit
that referenced
this pull request
Oct 12, 2022
jmklix
pushed a commit
that referenced
this pull request
Oct 12, 2022
jmklix
pushed a commit
that referenced
this pull request
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Our cpsell checks have been failing for a while, this fixes them by adding unknown words, and correctly spelling when appropriate.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.