Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delay load dll #2849

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Fix delay load dll #2849

merged 2 commits into from
Feb 8, 2024

Conversation

SergeyRyabinin
Copy link
Contributor

@SergeyRyabinin SergeyRyabinin commented Feb 7, 2024

Issue #, if available:
#2789 Static ALLOCATION_TAG and SERVICE_NAME symbols break DelayLoadDLLs on windows

This fixes the regression for the given usecase I introduced back in #2157
Description of changes:
Do not expose static const variables from headers
Set few integration tests to test this config
Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@SergeyRyabinin SergeyRyabinin force-pushed the sr/delayload branch 2 times, most recently from 935f618 to 86646fb Compare February 8, 2024 00:04
@SergeyRyabinin SergeyRyabinin merged commit eeddb44 into main Feb 8, 2024
3 of 4 checks passed
@SergeyRyabinin SergeyRyabinin deleted the sr/delayload branch February 8, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants