Change some variable name and use operation shape id to represent ope…

…ration shape
aws · Mar 21, 2023 · 6174ff2 · 6174ff2
1 parent 38963ce
commit 6174ff2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...egen/src/main/java/software/amazon/smithy/aws/go/codegen/customization/S3100Continue.java b/...egen/src/main/java/software/amazon/smithy/aws/go/codegen/customization/S3100Continue.java
@@ -27,7 +27,7 @@ public class S3100Continue implements GoIntegration {
     private static final String ADD_100Continue_Header = "add100Continue";
     private static final String ADD_100Continue_Header_INTERNAL = "Add100Continue";
     private static final String Continue_Client_Option = "ContinueHeaderThresholdBytes";
-    private static final Set<String> Put_Op_Set = new HashSet<>(Arrays.asList("PutObject", "UploadPart"));
+    private static final Set<String> Put_Op_ShapeId_Set = new HashSet<>(Arrays.asList("com.amazonaws.s3#PutObject", "com.amazonaws.s3#UploadPart"));
 
     /**
      * Return true if service is Amazon S3.
@@ -80,7 +80,7 @@ public List<RuntimeClientPlugin> getClientPlugins() {
         return ListUtils.of(
                 RuntimeClientPlugin.builder()
                         .operationPredicate((model, service, operation) ->
-                                isS3Service(model, service) && Put_Op_Set.contains(operation.getId().getName())
+                                isS3Service(model, service) && Put_Op_ShapeId_Set.contains(operation.getId().toString())
                         )
                         .registerMiddleware(MiddlewareRegistrar.builder()
                                 .resolvedFunction(SymbolUtils.createValueSymbolBuilder(ADD_100Continue_Header).build())

diff --git a/service/internal/s3shared/s3100continue.go b/service/internal/s3shared/s3100continue.go
@@ -8,7 +8,7 @@ import (
 )
 
 const s3100ContinueID = "S3100Continue"
-const defaultLimit int64 = 1024 * 1024 * 2
+const default100ContinueThresholdBytes int64 = 1024 * 1024 * 2
 
 // Add100Continue add middleware, which adds {Expect: 100-continue} header for s3 client HTTP PUT request larger than 2MB
 // or with unknown size streaming bodies, during operation builder step
@@ -32,7 +32,7 @@ func (m *s3100Continue) HandleBuild(
 ) (
 	out middleware.BuildOutput, metadata middleware.Metadata, err error,
 ) {
-	sizeLimit := defaultLimit
+	sizeLimit := default100ContinueThresholdBytes
 	switch {
 	case m.continueHeaderThresholdBytes == -1:
 		return next.HandleBuild(ctx, in)