Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build EndpointResolver with options built in at setup. #17

Closed
jasdel opened this issue Oct 25, 2017 · 0 comments · Fixed by #30
Closed

Build EndpointResolver with options built in at setup. #17

jasdel opened this issue Oct 25, 2017 · 0 comments · Fixed by #30
Projects
Config Story Refactoring

Comments

@jasdel
Copy link
Contributor

jasdel commented Oct 25, 2017

SDK's Usage of EndpointResolver should be updated so that the DisableSSL and DualStack aws.Config values can be removed. Ideally the EndpointResolver is constructed with these options at setup instead of at runtime.
@jasdel jasdel created this issue from a note in Config Story Refactoring (TODO) Oct 25, 2017
@jasdel jasdel moved this from TODO to In Progress in Config Story Refactoring Nov 6, 2017
@jasdel jasdel mentioned this issue Nov 6, 2017
Merged
@jasdel jasdel closed this as completed in #30 Nov 7, 2017
Config Story Refactoring automation moved this from In Progress to Done Nov 7, 2017
jasdel added a commit that referenced this issue Nov 7, 2017
@jasdel
Refactor endpoints to have a cleaner configuration story (#30)
295b9cc 
Updates the endpoints package so that customer configures endpoint
resolution options on the endpoint resolver directlly. This moves
the endpoint resolving options out of Config. This also clarifies
what the SDK will do if the customer provides a custom URL.

Config DisabeSSL, and UseDualStack moved to endpoints.ResolveOptions

Fix #17
Fix #18
@hjkatz hjkatz mentioned this issue Dec 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Config Story Refactoring
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor endpoints to have a cleaner configuration story
1 participant
@jasdel