codegen: Fix SDK's serialization of operations with empty inputs #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skotambkar
reviewed
Jan 22, 2021
...go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/JsonRpcProtocolGenerator.java
Show resolved
Hide resolved
...go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/JsonRpcProtocolGenerator.java
Show resolved
Hide resolved
jasdel
force-pushed
the
jasdel/fixup/JSONRPCEmptyReq
branch
from
74485be
to
4c87a6e
Compare
skotambkar
reviewed
Jan 22, 2021
...go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/JsonRpcProtocolGenerator.java
Show resolved
Hide resolved
jasdel
force-pushed
the
jasdel/fixup/JSONRPCEmptyReq
branch
2 times, most recently
from
29ad379
to
30562cc
Compare
jasdel
force-pushed
the
jasdel/fixup/JSONRPCEmptyReq
branch
2 times, most recently
from
65a68fe
to
854cdbc
Compare
skotambkar
reviewed
Jan 25, 2021
jasdel
force-pushed
the
jasdel/fixup/JSONRPCEmptyReq
branch
from
854cdbc
to
a92dfae
Compare
skotambkar
approved these changes
Jan 25, 2021
Fixes the JSON RPC API clients to serialize empty JSON objects for stub synthetic cloned inputs. Also this ensure empty JSON modeled inputs are correctly serialized. Previously the SDK would incorrectly skip serialization for JSON RPC input shapes with no members. Whereas JSON RPC requires operations with input modeled serialize empty JSON object.
jasdel
force-pushed
the
jasdel/fixup/JSONRPCEmptyReq
branch
from
a92dfae
to
55396a4
Compare
skotambkar
approved these changes
Jan 25, 2021
This was referenced Mar 15, 2021
Bump github.com/aws/aws-sdk-go-v2/config from 1.1.1 to 1.1.2
giantswarm/aws-ebs-csi-volume-limiter#8
Merged
Closed
build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.1.1 to 1.1.2
fsouza/s3-upload-proxy#157
Merged
Merged
This was referenced Mar 15, 2021
Merged
Bump github.com/aws/aws-sdk-go-v2/config from 1.1.1 to 1.1.2 in /backend
WinWisely268/glasspolish#21
Merged
Merged
Closed
Merged
Merged
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the JSON RPC API clients to serialize empty JSON objects for stub synthetic cloned inputs. Also this ensure empty JSON modeled inputs are correctly serialized. Previously the SDK would incorrectly skip serialization for JSON RPC input shapes with no members. Whereas JSON RPC requires operations with input modeled serialize empty JSON object.