Achieve DisableMRAP parity in config loaders #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucix-aws
approved these changes
Aug 16, 2023
isaiahvita
force-pushed
the
feat-disableMrapParity
branch
from
2c1473d
to
988350e
Compare
isaiahvita
force-pushed
the
feat-disableMrapParity
branch
from
988350e
to
29ac32d
Compare
aajtodd
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LoadOptionsconfig loader did not have aDisableMultiRegionAccessPointsoption with accompanying function helpers, which did not allow forDisableMultiRegionAccessPointsconfig resolver in the S3 client.Additionally, added a breakfix to correct a spelling issue from
DisableMultRegionAccessPointstoDisableMultiRegionAccessPointsFixes:
#2234
#2233
#2230