Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: defer config value type assertion to load stage instead of parse #2286

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

lucix-aws
Copy link
Contributor

@lucix-aws lucix-aws commented Sep 20, 2023

Closes #2276

Closes #2287

Removes the typed (int/float/bool) tokenization from aws config parsing (internal/ini) - the shared_config layer is now responsible for deciding whether a particular value it needs is valid.

@lucix-aws lucix-aws merged commit a436fe6 into main Sep 21, 2023
8 of 9 checks passed
@lucix-aws lucix-aws deleted the fix-parseconfig branch September 21, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants