Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authentication config guide #2426

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Add authentication config guide #2426

merged 2 commits into from
Dec 19, 2023

Conversation

lucix-aws
Copy link
Contributor

No description provided.

Copy link
Contributor

@isaiahvita isaiahvita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great first start. But i do think this document assumes some conceptual familiarity with auth scheme resolution. i dont think that anyone not already familiar with auth scheme resolution would understand how customize this to their needs (but maybe that is something we do want).

imo, if we wanted to make it easier for customers to customize this we should add more explanation around these steps, like whats the conceptual difference between auth scheme resolution and auth scheme selection. additionally, a diagram might help to show how these things fit together.

approving though because my comments arent blocking.

| Anonymous | `smithy.api#noAuth` | n/a | n/a | No authentication - no identity is required, and the request is not signed or authenticated. |

In {{% alias sdk-go %}}, the identity and signer components of an auth scheme
are configured on a service's client Options. The SDK will automatically pick
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Options missing code formatting. throughout this page, some have it and some dont. we should prob make all uses of Options have it

@isaiahvita
Copy link
Contributor

LGTM

@lucix-aws lucix-aws merged commit 766cb48 into documentation Dec 19, 2023
1 check passed
@lucix-aws lucix-aws deleted the doc-sraauth branch December 19, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants